From: | Tino Wildenhain <tino(at)wildenhain(dot)de> |
---|---|
To: | Bruce Momjian <bruce(at)momjian(dot)us> |
Cc: | Hannu Krosing <hannu(at)skype(dot)net>, Guido Goldstein <guido(dot)goldstein(at)a-nugget(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org |
Subject: | Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean, |
Date: | 2007-01-31 13:59:03 |
Message-ID: | 45C0A0A7.3030406@wildenhain.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers pgsql-patches |
Bruce Momjian schrieb:
> Hannu Krosing wrote:
>> Officially by who ?
>>
>> 2.3 was the first version to introduce bool as a subtype of int, in
>> 2.2.3 True and False were introduced as two variables pointing to
>> integers 1 and 0.
>>
>> So to make your patch ok on all python versions, just make it
>> conditional on python version being 2.3 or bigger, and return int for
>> pre-2.3.
>
> I thought about suggesting that, but do we want plpython to have
> different result behavior based on the version of python used? I didn't
> think so.
Why not? Python2.2 is rarely in use anymore and users of this would get
the same behavior. Users of python2.3 and up would get the additionally
cleaned boolean interface - also users which go the from __future__
import ... way. Thats how python works and develops forth and we should
not work against that from postgres side.
So I'm indeed +1 for conditional approach.
Regards
Tino
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2007-01-31 14:08:38 | Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean, |
Previous Message | Alvaro Herrera | 2007-01-31 13:34:25 | Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean, |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2007-01-31 14:08:38 | Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean, |
Previous Message | Alvaro Herrera | 2007-01-31 13:34:25 | Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean, |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2007-01-31 14:08:38 | Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean, |
Previous Message | Alvaro Herrera | 2007-01-31 13:34:25 | Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean, |