Amcheck verification of GiST and GIN

From: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Amcheck verification of GiST and GIN
Date: 2022-05-30 09:40:06
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hello world!

Few years ago we had a thread with $subj [0]. A year ago Heikki put a lot of effort in improving GIN checks [1] while hunting a GIN bug.
And in view of some releases with a recommendation to reindex anything that fails or lacks amcheck verification, I decided that I want to review the thread.

PFA $subj incorporating all Heikki's improvements and restored GiST checks. Also I've added heapallindexed verification for GiST. I'm sure that we must add it for GIN too. Yet I do not know how to implement it. Maybe just check that every entry generated from heap present in entry tree? Or that every tids is present in the index?

GiST verification does parent check despite taking only AccessShareLock. It's possible because when the key discrepancy is found we acquire parent tuple with lock coupling. I'm sure that this is correct to check keys this way. And I'm almost sure it will not deadlock, because split is doing the same locking.

What do you think?

Best regards, Andrey Borodin.


Attachment Content-Type Size
v10-0001-Amcheck-for-GIN-and-GiST.patch application/octet-stream 80.5 KB


Browse pgsql-hackers by date

  From Date Subject
Next Message 2022-05-30 09:49:58 RE: Multi-Master Logical Replication
Previous Message 2022-05-30 08:51:59 RE: Perform streaming logical transactions by background workers and parallel apply