Re: column ordering, was Re: [PATCHES] Enums patch v2

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Zeugswetter Andreas ADI SD <ZeugswetterA(at)spardat(dot)at>
Cc: Martijn van Oosterhout <kleptog(at)svana(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Treat <xzilla(at)users(dot)sourceforge(dot)net>, pgsql-hackers(at)postgresql(dot)org, Gregory Stark <stark(at)enterprisedb(dot)com>
Subject: Re: column ordering, was Re: [PATCHES] Enums patch v2
Date: 2006-12-21 15:27:12
Message-ID: 458AA7D0.1020802@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Zeugswetter Andreas ADI SD wrote:
>> I'm not sure how much you can do with typing. Things like heap_getattr
>> are macros, and thus untyped. Most places use attr as an index to an
>> array, which also can't be type checked.
>>
>> If you switched everything over to inline functions you might
>> get it to
>> work, but that's about it.
>>
>> IMHO the best solution is to offset the logical numbers by some
>> constant...
>>
>
> Um, surely you meant "offset the physical numbers". Imho the logical
> numbers
> need to stay 1-n, because those numbers are used way more often and are
> more user visible than the physical.
>
>
>

I don't think we should expose the offset to user view at all - this is
just for internal use, no?

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-12-21 15:29:14 Re: ERROR: tuple concurrently updated
Previous Message Tom Lane 2006-12-21 15:22:41 Re: log_min_error_statement and parameters value

Browse pgsql-patches by date

  From Date Subject
Next Message Martijn van Oosterhout 2006-12-21 15:37:03 Re: column ordering, was Re: [PATCHES] Enums patch v2
Previous Message Zeugswetter Andreas ADI SD 2006-12-21 14:39:07 Re: column ordering, was Re: [PATCHES] Enums patch v2