Enums patch v2

From: Tom Dunstan <pgsql(at)tomd(dot)cc>
To: pgsql-patches(at)postgresql(dot)org
Subject: Enums patch v2
Date: 2006-12-19 02:34:36
Message-ID: 45874FBC.9000804@tomd.cc
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers pgsql-patches

Hi all

Here is an updated version of the enums patch. It has been brought up to
date and applies against current CVS HEAD. The original email is at [1],
and describes the implementation.

This version contains sgml documentation, and contains the missing
bounds checks and error codes noted in the last email.

As mentioned before, the only part that I'm not super keen on is the
hack required to pass the type oid in to the text-to-enum cast function,
since normally those take type mods but not type oids. I wasn't sure how
else to get a cast working though, short of allowing another type of
cast function which accepts type oids as well. That seemed overkill for
just one case, though, and was getting a bit beyond the realms of what I
wanted to get done with this patch.

Anyway, it's reasonably feature complete and should be appropriately
documented now, so feedback gratefully accepted.



[1] http://archives.postgresql.org/pgsql-patches/2006-09/msg00000.php

Attachment Content-Type Size
enums.patch.gz application/x-gzip 23.8 KB


Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2006-12-19 03:23:59 Re: pg_restore fails with a custom backup file
Previous Message Takayuki Tsunakawa 2006-12-19 00:47:59 Re: Question about debugging bootstrapping and catalog entries

Browse pgsql-patches by date

  From Date Subject
Next Message Heikki Linnakangas 2006-12-19 08:09:47 Re: Enums patch v2
Previous Message Tom Lane 2006-12-18 21:06:24 Re: Typo in pg_dump documentation and new suggestion for Release Notes