Re: [PATCH] fix portability issues in acinclude.m4

Thanks Max, patch applied.

Regards, Dave.

Max Khon wrote:
> Hi!
>
> Attached patch fixes portability issues in acinclude.m4
> (and generated configure). The patch is made against pgadmin 1.6.0 source
> tree.
>
> Note that "test" utility on FreeBSD (and probably on other *BSD)
> does not understand "==" operator. Strings shall be compared using "=" operator.
>
> /fjoe
>
>
> ------------------------------------------------------------------------
>
> --- acinclude.m4.orig Wed Nov 29 03:52:26 2006
> +++ acinclude.m4 Wed Nov 29 03:52:43 2006
> @@ -15,7 +15,7 @@
>
> AC_DEFUN([CHECK_CPP_COMPILER],
> [
> - if test "$ac_cv_prog_cxx_g" == no; then
> + if test "$ac_cv_prog_cxx_g" = no; then
> AC_MSG_ERROR([could not find a suitable C++ compiler to build pgAdmin])
> fi
> ])
> @@ -27,7 +27,7 @@
> [
> AC_ARG_WITH(wx-version, [ --with-wx-version=<version number> the wxWidgets version in major.minor format (default: 2.7)],
> [
> - if test "$withval" == yes; then
> + if test "$withval" = yes; then
> AC_MSG_ERROR([you must specify a version number when using --with-wx-version=<version number>])
> else
> if test -z "$withval"; then
> @@ -429,7 +429,7 @@
> WX_OLD_LDFLAGS="$LDFLAGS"
> WX_OLD_CPPFLAGS="$CPPFLAGS"
>
> - if test "$BUILD_DEBUG" == yes
> + if test "$BUILD_DEBUG" = yes
> then
> WX_NEW_CPPFLAGS=`${WX_CONFIG} --cppflags --unicode=yes --debug=yes --version=${WX_VERSION} 2> /dev/null`
> CPPFLAGS="$CPPFLAGS $WX_NEW_CPPFLAGS -g -O0"
> @@ -548,7 +548,7 @@
> echo "PostgreSQL directory: $PG_HOME"
> echo "PostgreSQL pg_config binary: $PG_CONFIG"
> echo "PostgreSQL version: $PG_VERSION"
> - if test "$PG_SSL" == yes
> + if test "$PG_SSL" = yes
> then
> echo "PostgreSQL SSL support: Present"
> else
> @@ -559,25 +559,25 @@
> echo "wxWidgets wx-config binary: $WX_CONFIG"
> echo "wxWidgets version: wxWidgets "`$WX_CONFIG --version --version=$WX_VERSION`
> echo
> - if test "$BUILD_DEBUG" == yes
> + if test "$BUILD_DEBUG" = yes
> then
> echo "Building a debug version of pgAdmin: Yes"
> else
> echo "Building a debug version of pgAdmin: No"
> fi
> - if test "$BUILD_STATIC" == yes
> + if test "$BUILD_STATIC" = yes
> then
> echo "Statically linking pgAdmin: Yes"
> else
> echo "Statically linking pgAdmin: No"
> fi
> - if test "$BUILD_APPBUNDLE" == yes
> + if test "$BUILD_APPBUNDLE" = yes
> then
> echo "Building a Mac OS X appbundle: Yes"
> else
> echo "Building a Mac OS X appbundle: No"
> fi
> - if test "$INSTALL_DOCS" == yes
> + if test "$INSTALL_DOCS" = yes
> then
> echo "Include documentation: Yes"
> else
>
>
> ------------------------------------------------------------------------
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 7: You can help support the PostgreSQL project by donating at
>
> http://www.postgresql.org/about/donate