Re: Win32 signals & sockets

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Magnus Hagander" <mha(at)sollentuna(dot)net>
Cc: "PostgreSQL Patches" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Win32 signals & sockets
Date: 2004-11-17 00:18:10
Message-ID: 4560.1100650690@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-patches

"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
> This patch *replaces* the previous one. Contains the exact same changes,
> except it *also* contains the move of the backend parameter file to
> shared memory on win32.

Committed with some small editorializing. Possibly the weight of my
concern about further dividing the Unix and Win32 cases can be brought
home to you by pointing out that the non-Windows EXEC_BACKEND case had
three different compile failures after applying the patch.

I think the error recovery in the Windows internal_forkexec() routine
is pretty shoddy --- most of the failure paths leak resources of one
variety or another. Perhaps you can fix that during your upcoming
code refactoring.

regards, tom lane

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Neil Conway 2004-11-17 00:20:02 minor restrpos / markpos optimization
Previous Message John Hansen 2004-11-16 23:46:21 Re: [PATCHES] plperl Safe restrictions