Skip site navigation (1) Skip section navigation (2)

Re: Win32 signals & sockets

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Magnus Hagander" <mha(at)sollentuna(dot)net>
Cc: "PostgreSQL Patches" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Win32 signals & sockets
Date: 2004-11-17 00:18:10
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-patches
"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
> This patch *replaces* the previous one. Contains the exact same changes,
> except it *also* contains the move of the backend parameter file to
> shared memory on win32.

Committed with some small editorializing.  Possibly the weight of my
concern about further dividing the Unix and Win32 cases can be brought
home to you by pointing out that the non-Windows EXEC_BACKEND case had
three different compile failures after applying the patch.

I think the error recovery in the Windows internal_forkexec() routine
is pretty shoddy --- most of the failure paths leak resources of one
variety or another.  Perhaps you can fix that during your upcoming
code refactoring.

			regards, tom lane

In response to

pgsql-patches by date

Next:From: Neil ConwayDate: 2004-11-17 00:20:02
Subject: minor restrpos / markpos optimization
Previous:From: John HansenDate: 2004-11-16 23:46:21
Subject: Re: [PATCHES] plperl Safe restrictions

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group