Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Greg Stark <gsstark(at)mit(dot)edu>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY)
Date: 2009-08-12 05:00:54
Message-ID: 4554.1250053254@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> The reason this is like this is that the indent binary modifies the
> prototype exactly like the function definition, and then the awk program
> that's used in the pipeline "pulls up" the second line:

> # Move prototype names to the same line as return type. Useful for ctags.
> # Indent should do this, but it does not. It formats prototypes just
> # like real functions.

> In this day and age there's probably no reason to do this.

Um, sorry, no reason to do which?

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2009-08-12 13:26:29 Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY)
Previous Message Alvaro Herrera 2009-08-12 04:54:40 Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY)

Browse pgsql-hackers by date

  From Date Subject
Next Message Torsten Zühlsdorff 2009-08-12 06:48:45 Re: Why is vacuum_freeze_min_age 100m?
Previous Message Tom Lane 2009-08-12 04:58:29 Re: TODO: fix priority of ordering of read and write light-weight locks