| From: | Michael Paesold <mpaesold(at)gmx(dot)at> |
|---|---|
| To: | pgsql-jdbc(at)postgresql(dot)org |
| Subject: | [PATCH] Escaping of SAVEPOINT names |
| Date: | 2006-11-05 21:18:44 |
| Message-ID: | 454E5534.5050007@gmx.at |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-jdbc |
Escaping of savepoint names in org.postgresql.jdbc3.PSQLSavepoint is
incorrect. Backslashes in (double-quoted) savepoint names are doubled
for escaping, but AFAIK, and as my testing shows, savepoint names are
like identifiers, so regular identifier quoting applies to them.
Therefore backslashes should not be doubled, because they have no
special meaning in a double-quoted string.
While at it, don't use the string literal "\"" just to append a single
double-quote character to a string buffer.
Best Regards,
Michael Paesold
| Attachment | Content-Type | Size |
|---|---|---|
| savepoint-names.patch | text/x-patch | 1.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paesold | 2006-11-05 21:28:30 | [PATCH] Comments in PGbytea byte[] to pgstring conversion |
| Previous Message | Michael Paesold | 2006-11-05 20:46:31 | JDBC Support for standard_conforming_strings |