[PATCH] amroutine->amsupport from numeric to defined constants

From: Nikolay Shaplov <n(dot)shaplov(at)postgrespro(dot)ru>
To: pgsql-hackers(at)postgresql(dot)org
Subject: [PATCH] amroutine->amsupport from numeric to defined constants
Date: 2016-04-26 13:17:16
Message-ID: 4541040.vN1QeMLbeJ@nataraj-amd64
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


While working with postgres code, I found that for gist index number of
amsupport procs are defined two times. First in src/include/access/gist.h

#define GISTNProcs 9

and second in src/backend/access/gist/gist.c

amroutine->amsupport = 9;

I think this number should be specified only once, in .h file.

So I would offer a patch for all access methods. That changes amsupport and
amstrategies from numbers to defined constants. (I've added two of them where
they were missing)

See attachment.

If it is good, I will add it to the commitfest.

--
Nikolay Shaplov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company

Attachment Content-Type Size
amsupport-to-defined-constants2.diff text/x-patch 3.2 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-04-26 13:40:53 Re: Protocol buffer support for Postgres
Previous Message Christian Ullrich 2016-04-26 13:09:42 Parallel build with MSVC