Re: Improving psql's \password command

From: "Bossart, Nathan" <bossartn(at)amazon(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Improving psql's \password command
Date: 2021-11-19 00:41:30
Message-ID: 450C0AD1-CF21-4056-A9EE-6201E9763FC9@amazon.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 11/17/21, 4:38 PM, "Bossart, Nathan" <bossartn(at)amazon(dot)com> wrote:
> On 11/17/21, 4:15 PM, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> As you mentioned, there are several other simple_prompt() calls
>> that could usefully be improved. (I think the one in startup.c
>> may be OK because we've not set up the SIGINT handler yet,
>> though.) I wondered whether it's worth refactoring some more
>> to have just one function that sets up the context mechanism.
>
> I'll get started on these.

Okay, here is an attempt at adding control-C support for \prompt and
\connect. It was reasonably straightforward. I did have to teach
simple_prompt_extended() to add a newline after a cancellation when
"echo" is true.

I think that's it for psql. After a quick glance, I didn't see any
other obvious candidates for control-C support, but I'll look a little
closer to be sure.

Nathan

Attachment Content-Type Size
0001-Add-control-C-support-for-psql-s-prompt-and-connect-.patch application/octet-stream 4.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2021-11-19 01:49:32 Re: pg_get_publication_tables() output duplicate relid
Previous Message Peter Smith 2021-11-19 00:05:31 Re: row filtering for logical replication