currentItemData & currentMarkData

From: Heikki Linnakangas <heikki(at)enterprisedb(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: currentItemData & currentMarkData
Date: 2006-09-12 14:01:36
Message-ID: 4506BDC0.2050705@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

It has bothered me for some time that we have currentItemData and
currentMarkData fields in IndexScanDescData, while it's really indexam's
private data. They should be in the indexam opaque structure.

At the moment, they're used in gist and hash access methods, and they're
not used in b-tree and gin. The new bitmap index code uses them, but
only as an internal boolean flag indicating that the scan has been
initialized, so that should be fixed anyway.

How about removing those fields from IndexScanDesc?

There's also is_multiscan field which is set but never read.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-09-12 14:11:15 Re: Bitmap index status
Previous Message Tom Lane 2006-09-12 13:59:16 AIX shared libraries (was Re: [PATCHES] Fix linking of OpenLDAP libraries)