| From: | "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com> |
|---|---|
| To: | Andy Fan <zhihui(dot)fan1213(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Floris Van Nee <florisvannee(at)optiver(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, "PostgreSQL Hackers" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, "rushabh(dot)lathia(at)gmail(dot)com" <rushabh(dot)lathia(at)gmail(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
| Subject: | RE: [PATCH] Keeps tracking the uniqueness with UniqueKey |
| Date: | 2020-10-08 04:12:37 |
| Message-ID: | 44a8eaf67d8a439d949e778dd6279e18@G08CNEXMBPEKD05.g08.fujitsu.local |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi
I have a look over this patch and find some typos in 0002.
1.Some typos about unique:
There are some spelling mistakes about "unique" in code comments and README.
Such as: "+However we define the UnqiueKey as below."
2.function name about initililze_uniquecontext_for_joinrel:
May be it should be initialize_ uniquecontext_for_joinrel.
3.some typos in comment:
+ * baserelation's basicrestrictinfo. so it must be in ON clauses.
I think it shoule be " basicrestrictinfo " => "baserestrictinfo".
Besides, I think list_copy can be used to simplify the following code.
(But It seems the type of expr is still in discussion, so this may has no impact )
+ List *exprs = NIL;
...
+ foreach(lc, unionrel->reltarget->exprs)
+ {
+ exprs = lappend(exprs, lfirst(lc));
+ }
Best regards,
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2020-10-08 04:37:11 | Re: Transactions involving multiple postgres foreign servers, take 2 |
| Previous Message | Greg Nancarrow | 2020-10-08 03:12:28 | Re: Parallel copy |