Re: [COMMITTERS] pgsql: Second try committing the path

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Chris Browne <cbbrowne(at)acm(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Second try committing the path
Date: 2006-09-03 15:44:52
Message-ID: 44FAF874.8010204@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Andrew Dunstan wrote:
> Tom Lane wrote:
>>
>> The buildfarm script is supposed to complain about unexpected files in
>> the repository --- I wonder if it is fooled by the .cvsignore entries
>> for these files?
>>
>
> Yes, we do. A patch made in July 2005 has this comment:
>
> "ignore files listed in cvsignore files - this will stop inappropriate
> triggering of vpath builds."
>
>
> Perhaps I should only do that for vpath builds. Or perhaps I should
> even remove them at the end of a build, since we don't expect any of
> those files in a clean repo, do we?
>
> Also, in case anyone has not got the message yet: Don't ever build by
> hand in the buildfarm repo. Ever. I mean it. Use a copy.
>
>

I have just committed a patch that removes the cvsignore trap. This
should be safe as we now remove them at the end of a buildfarm vpath run.

cheers

andrew

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2006-09-03 15:59:39 pgsql: Arrange for GetSnapshotData to copy live-subtransaction XIDs from
Previous Message User Andrewd 2006-09-03 15:28:55 pgbuildfarm - client-code: Don't ignore files listed in a cvsignore file

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-09-03 16:08:58 Re: CSStorm occurred again by postgreSQL8.2
Previous Message Sergey E. Koposov 2006-09-03 15:44:32 Re: GIN FailedAssertions on Itanium2 with Intel compiler