Re: Adding fulldisjunctions to the contrib

From: "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>
To: Dave Page <dpage(at)vale-housing(dot)co(dot)uk>
Cc: "Jonah H(dot) Harris" <jonah(dot)harris(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, Tzahi Fadida <Tzahi(dot)ML(at)gmail(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Adding fulldisjunctions to the contrib
Date: 2006-08-27 10:47:49
Message-ID: 44F17855.1000207@commandprompt.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Dave Page wrote:
>
>
> -----Original Message-----
> From: pgsql-patches-owner(at)postgresql(dot)org on behalf of Jonah H. Harris
> Sent: Sun 8/27/2006 3:24 AM
> To: Joshua D. Drake
> Cc: Andrew Dunstan; Bruce Momjian; Tzahi Fadida; pgsql-patches(at)postgresql(dot)org
> Subject: Re: [PATCHES] Adding fulldisjunctions to the contrib
>
>> It's odd, only 10 people have commented on this thread; 4 of which are
>> core members, 2 in favor and 2 against. Yet, we're having an argument
>> on why this wasn't included. Unless this is the new math, 2 vs. 2
>> seems like a tie to me.
>
> Y'know I was gonna check up on that because my recollection was that it was a 2/2 split as well, though I thought that was of people who made their view clear rather than just -core (whose opinion in this case is no more important than any of the other long time contributors imho). Don't suppose you noted the views of the other 6?

IIRC some of the rejection points, was the code:

1. Is not quite complete
2. Does not follow postgresql style guidelines

Those two items make it impossible to include Full disjunctions in core.
I believe those two points were made by Tom but I can't find his
response so if I am on crack -- I apologize in advance.

Sincerely,

Joshua D. Drake

--

=== The PostgreSQL Company: Command Prompt, Inc. ===
Sales/Support: +1.503.667.4564 || 24x7/Emergency: +1.800.492.2240
Providing the most comprehensive PostgreSQL solutions since 1997
http://www.commandprompt.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jonah H. Harris 2006-08-27 12:36:15 Re: [PATCHES] Adding fulldisjunctions to the contrib
Previous Message Peter Eisentraut 2006-08-27 10:37:16 Re: [PATCHES] Adding fulldisjunctions to the contrib

Browse pgsql-patches by date

  From Date Subject
Next Message Jonah H. Harris 2006-08-27 12:36:15 Re: [PATCHES] Adding fulldisjunctions to the contrib
Previous Message Peter Eisentraut 2006-08-27 10:37:16 Re: [PATCHES] Adding fulldisjunctions to the contrib