Re: Patch - Have psql show current values

From: Dhanaraj M <Dhanaraj(dot)M(at)Sun(dot)COM>
To: pgsql-patches(at)postgresql(dot)org
Subject: Re: Patch - Have psql show current values
Date: 2006-08-24 05:32:20
Message-ID: 44ED39E4.3030500@sun.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Hi all,

This patch was discussed a few months ago.
I could not complete this patch at that time.
I hope that the current version of my patch is acceptable.

Patch details:
**************
1. Assign a new field called 'Seq Value' for \ds command
2. All the sequence values are '1' initially
3. After executing the query, call AssignSeqValue()
4. This function assigns the respective sequence values back to the
resultset

Please review and comment on this patch.

Thanks
Dhanaraj

Tom Lane wrote:

>Dhanaraj M <Dhanaraj(dot)M(at)Sun(dot)COM> writes:
>
>
>>However, it was not possible to display the seq. value using this.
>>Hence, I made a small change in the currval() function, so that it
>>retrieves the last_value
>>even if the the value is not cached.
>>
>>
>
>Breaking currval()'s semantics is not an acceptable solution for this.
>
>The best, fully backward compatible solution is for psql to issue
>"SELECT last_value FROM <seq>" queries to get the values. This might
>be a bit tricky to wedge into the structure of describe.c, but I don't
>see any fundamental reason why it can't be done.
>
> regards, tom lane
>
>

Attachment Content-Type Size
patch.patch text/x-patch 2.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2006-08-24 06:25:29 Re: [PATCHES] Patch - Have psql show current values
Previous Message Tom Lane 2006-08-24 04:09:43 Re: Some minor changes to pgbench

Browse pgsql-patches by date

  From Date Subject
Next Message Peter Eisentraut 2006-08-24 06:25:29 Re: [PATCHES] Patch - Have psql show current values
Previous Message Tom Lane 2006-08-24 04:09:43 Re: Some minor changes to pgbench