From: | Joe Conway <mail(at)joeconway(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | David Fetter <david(at)fetter(dot)org>, rse(at)engelschall(dot)com, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [BUGS] Patch to allow C extension modules to initialize/finish |
Date: | 2006-08-03 23:00:55 |
Message-ID: | 44D28027.3090608@joeconway.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
Tom Lane wrote:
> Joe Conway <mail(at)joeconway(dot)com> writes:
>>Tom Lane wrote:
>>
>>>Also, if we do this we probably ought to remove the special-purpose
>>>hack for preload_libraries to specify an init function --- it should
>>>just happen by default. Any objections to simplifying that?
>
>>The original idea of using the init function with preload_libraries was
>>to eliminate library startup that was expensive and only needed once.
>>Specifically in the case of libR (and presumably other libraries as
>>well), the init time was much greater than the actual library load time.
>>If it is removed from preload_libraries, then we'll pay that price for
>>every backend startup, no?
>
> No, my thought is that you'd rename PL/R's init function to PG_init, and
> then it'd get called automagically without needing to assume that the DBA
> remembers to specify it in preload_libraries. If there's a reason *not*
> to do that then it'd be a strike against this whole proposal, methinks.
Oh, well that sounds perfect to me. At least in the case of a procedural
language handler you can easily initialize and cache anything that must
be done per-backend anyway. It's the "expensive but must be done at
least once stuff" that was a problem. As long as that happens, I'm
happy. And if we eliminate a dba dependency, so much the better.
Joe
From | Date | Subject | |
---|---|---|---|
Next Message | ivankob | 2006-08-04 07:12:53 | BUG #2563: In rules: recalculation of input expression on each access |
Previous Message | Tom Lane | 2006-08-03 22:58:49 | Re: BUG #2554: ILIKE operator works incorrectly |
From | Date | Subject | |
---|---|---|---|
Next Message | Gavin Sherry | 2006-08-04 00:36:45 | Re: Values list-of-targetlists patch for comments (was Re: |
Previous Message | Zoltan Boszormenyi | 2006-08-03 22:58:08 | Re: GENERATED ... AS IDENTITY, Was: Re: Feature Freeze |