Re: [PATCHES] [COMMITTERS] pgsql: /contrib/cube improvements:

From: Joshua Reich <josh(at)root(dot)net>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] [COMMITTERS] pgsql: /contrib/cube improvements:
Date: 2006-07-27 19:56:27
Message-ID: 44C91A6B.7040903@root.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers pgsql-patches

I am uncomfortable with the fact that the ordering is different on
different architectures. AFAIK, all I did was port the ordering function
from V0 to V1.

Short of me continually submitting patches until I fix it, is there an
easier way, or some pointers as to what I should be looking for in the code?

The function in question, I believe, is cube_cmp_v0().

Josh

Andrew Dunstan wrote:
> I wrote:
>
>>
>> I have applied this and made an attempt to fix
>> cube/expected/cube_1.out - we will still need to keep an eye on the
>> various cube tests.
>>
>
> It looks like with the current tests we will need at least one more
> possible results file (gazelle and asp on buildfarm agree about negative
> zero but disagree about ordering, so we would need to handle both
> variants which were previously handed in just cube_1.out). That would
> make four for this little module. Is it just me or does that seem
> excessive? Can we possibly simplify things a bit?
>
> cheers
>
> andrew

--
Joshua Reich
Finance and Corporate Development
ROOT Exchange, A Division of ROOT Markets
601 W. 26th St. / Suite 1500
New York, NY 10001
W - (212) 645 6320 x 7101
M / T - (646) 427 7959
E - josh(at)rootexchange(dot)com

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2006-07-27 19:58:39 pgsql: revert last change - broke non-AIX platforms.
Previous Message Tom Lane 2006-07-27 19:52:07 pgsql: Aggregate functions now support multiple input arguments.

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2006-07-27 20:02:18 Re: [COMMITTERS] pgsql: another try at keeping AIX/ppc
Previous Message Tom Lane 2006-07-27 19:54:09 Re: patch implementing the multi-argument aggregates (SOC project)

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2006-07-27 20:29:53 Re: New shared memory hooks proposal (was Re:
Previous Message Tom Lane 2006-07-27 19:54:09 Re: patch implementing the multi-argument aggregates (SOC project)