Re: [HACKERS] [COMMITTERS] pgsql: /contrib/cube improvements: Update

From: Joshua Reich <josh(at)root(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] [COMMITTERS] pgsql: /contrib/cube improvements: Update
Date: 2006-07-27 14:21:59
Message-ID: 44C8CC07.802@root.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers pgsql-patches

Ok. Here is a diff taken from the top of the contrib tree. I have
suppressed the notices in both the cube and earthdistance packages. All
tests pass.

Josh

Tom Lane wrote:
> Joshua Reich <josh(at)root(dot)net> writes:
>> I'm not sure exactly what to do here. I tried simply doing
>> CREATE TYPE cube;
>
>> But I still get NOTICE's to the effect of "return type cube is only a
>> shell" or "argument type cube is only a shell".
>
> Hmm ... I remembered that we'd discussed suppressing those NOTICEs,
> but I guess we didn't actually do it.
>
>> I'm not sure how to do this to get zero NOTICES.
>
> I think what I'd suggest is making earthdistance do
>
> SET client_min_messages = warning;
> include the file
> RESET client_min_messages;
>
> This will avoid any future flap in the test output if we do remove
> those notices.
>
> regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> message can get through to the mailing list cleanly

Attachment Content-Type Size
contrib-cube_earthdistance.diff text/plain 46.8 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2006-07-27 14:50:47 Re: [HACKERS] [COMMITTERS] pgsql: /contrib/cube improvements:
Previous Message User Diogob 2006-07-27 14:11:19 xlogviewer - xlogviewer:

Browse pgsql-hackers by date

  From Date Subject
Next Message Zdenek Kotala 2006-07-27 14:24:43 Re: Allow commenting of variables in postgresql.conf to -
Previous Message Alvaro Herrera 2006-07-27 14:21:47 Re: GUC with units, details

Browse pgsql-patches by date

  From Date Subject
Next Message Zdenek Kotala 2006-07-27 14:24:43 Re: Allow commenting of variables in postgresql.conf to -
Previous Message Tom Lane 2006-07-27 13:46:31 Re: [COMMITTERS] pgsql: /contrib/cube improvements: Update