Re: [COMMITTERS] pgsql: /contrib/cube improvements: Update

From: Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Joshua Reich <josh(at)root(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: /contrib/cube improvements: Update
Date: 2006-07-26 08:34:52
Message-ID: 44C7292C.5020909@kaltenbrunner.cc
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers pgsql-patches

Bruce Momjian wrote:
> Tom Lane wrote:
>> Joshua Reich <josh(at)root(dot)net> writes:
>>>> The problem is that there are new functions in cube.sql, so the output
>>>> is now different and breaks the diff (to state the obvious).
>> Actually, the new theory on this is that you should explicitly create
>> a shell type first:
>>
>> CREATE TYPE cube;
>>
>> and then create the functions, and then make the type "for real".
>>
>> This will still involve a change in the earthdistance expected
>> output (down to zero expected NOTICEs) but if we're gonna fix it
>> then let's fix it right.
>
> OK, I will wait for the next patch. Funny I tested the cube regression
> test, but not earthdistance.

FYI: the buildfarm-script has a "no reporting" mode and can use
preexisting sourcetrees - that's what I regulary use to test patches and
modifications to the source.

Stefan

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2006-07-26 11:35:56 pgsql: Convert effective_cache_size to an integer, for better
Previous Message Tatsuo Ishii 2006-07-26 07:24:50 pgsql: New features contributed by Tomoaki Sato.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tatsuo Ishii 2006-07-26 08:45:54 pgbench enhancements
Previous Message Joachim Wieland 2006-07-26 08:17:22 Re: Time zone definitions to config files

Browse pgsql-patches by date

  From Date Subject
Next Message Zdenek Kotala 2006-07-26 11:24:19 Re: Patch for units in postgresql.conf
Previous Message Joachim Wieland 2006-07-26 08:17:22 Re: Time zone definitions to config files