| From: | Joe Conway <mail(at)joeconway(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Christopher Kings-Lynne <chris(dot)kings-lynne(at)calorieking(dot)com>, "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Bernd Helmle <mailings(at)oopsware(dot)de>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Susanne Ebrecht <susanne(dot)ebrecht(at)credativ(dot)de> |
| Subject: | Re: Values list-of-targetlists patch for comments (was Re: |
| Date: | 2006-07-24 16:32:37 |
| Message-ID: | 44C4F625.2050304@joeconway.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-docs pgsql-hackers pgsql-patches |
Tom Lane wrote:
>>
>>>There are basically two ways you could go about this:
>>>1. Make a new jointree leaf node type to represent a VALUES construct,
>>>and dangle the list of lists of expressions off that.
>>>2. Make a new RangeTblEntry type to represent a VALUES construct, and
>>>just put a RangeTblRef to it into the jointree. The expressions
>>>dangle off the RangeTblEntry.
>
> You seem to have done *both*, which is certainly not what I had in mind.
> I'd drop the RangeTblEntry changes, I think.
Good feedback -- thanks! But without the RTE, how would VALUES in the
FROM clause work? Or should I just drop that part and focus on just the
InsertStmt case?
Joe
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2006-07-24 17:09:29 | Re: Values list-of-targetlists patch for comments (was Re: [HACKERS] 8.2 features?) |
| Previous Message | Tom Lane | 2006-07-24 16:12:11 | Re: Values list-of-targetlists patch for comments (was Re: [HACKERS] 8.2 features?) |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2006-07-24 16:33:36 | Re: [PATCHES] Generic Monitoring Framework with DTrace patch |
| Previous Message | Joshua D. Drake | 2006-07-24 16:23:08 | Re: plPHP and plRuby |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2006-07-24 16:33:36 | Re: [PATCHES] Generic Monitoring Framework with DTrace patch |
| Previous Message | Tom Lane | 2006-07-24 16:12:11 | Re: Values list-of-targetlists patch for comments (was Re: [HACKERS] 8.2 features?) |