From: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-patches(at)postgresql(dot)org |
Subject: | Re: New regresion test for SET/RESET commnad |
Date: | 2006-07-19 14:06:26 |
Message-ID: | 44BE3C62.6070909@sun.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Tom Lane wrote:
> Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> writes:
>> I created new regression test for check SET and RESET commands and
>> configuration subsystem.
>
> Does this actually accomplish anything? The checks that retail SETs
> and RESETs work seem redundant with numerous existing tests.
I think no. I have not found any test specialized to GUC subsystem. Some
tests use SET/RESET command but only in same situation. I want to test
"complete" GUC subsystem. My patch is first step.
> The SELECT
> from pg_settings is a seriously bad idea: it adds 100K of bloat to the
> regression files, tests nothing of great interest, and will cause
> regression test failures under a large variety of scenarios
Yes, you have right. My idea was check if GUC subsystem setups all
settings correctly, but this test should bring more problems than
advantages. I probably take subset ( one for each datatype) of relative
stable settings, and perform checks on this set. However, this test
require be first of all regression tests.
Zdenek
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2006-07-19 14:12:08 | Re: [HACKERS] pg_regress in C |
Previous Message | Andrew Dunstan | 2006-07-19 11:33:15 | pg_regress breaks on msys |