| From: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Kirill Reshke <reshkekirill(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix gistkillitems & add regression test to microvacuum |
| Date: | 2026-01-20 10:30:30 |
| Message-ID: | 449DFC8A-CF54-493E-9366-AF9C73C782AA@yandex-team.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 15 Jan 2026, at 22:59, Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
>
> PFA v2 which leaves the test in-place.
>
> Also commit message improvements.
Yeah, killtuples for GiST root page is broken. Your patch is fixing it.
I don't think we should backpatch this, the bug is harmless, but for master the patch LGTM.
It would be good to assign so->curBlkno and so->curBlkno together. But gistScanPage() is the only place with access to the block number.
+# Test gist, but with fewer rows - that killitems used to be buggy.
Probably, in this comment we can explicitly say that killitems was buggy, but now is fixed.
Thanks!
Best regards, Andrey Borodin.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shveta malik | 2026-01-20 10:38:33 | Re: Proposal: Conflict log history table for Logical Replication |
| Previous Message | Tatsuo Ishii | 2026-01-20 10:28:34 | Re: Row pattern recognition |