From: | Andreas Pflug <pgadmin(at)pse-consulting(dot)de> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Dhanaraj(dot)M(at)Sun(dot)COM, pgsql-patches(at)postgresql(dot)org |
Subject: | Re: Patch for - Allow server logs to be remotely read |
Date: | 2006-06-09 09:37:35 |
Message-ID: | 4489415F.7050107@pse-consulting.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
>
>>Tom Lane wrote:
>>
>>>I wonder if we should take pg_read_file (and the rest of genfile.c)
>>>back out of the backend and stick them into contrib/adminpack.
>
>
>>I thought about that but what we have in the backend now is read-only
>>which basically could be done using COPY, so I don't see any security
>>value to moving them out. They are super-user only just like COPY.
>
>
> The you-can-do-it-with-COPY argument doesn't apply to pg_ls_dir, nor to
> pg_stat_file, and I find it unconvincing even for pg_read_file. COPY
> isn't at all friendly for trying to read binary files, for instance.
pg_file_read returns text which isn't binary-friendly either.
Regards,
Andreas
From | Date | Subject | |
---|---|---|---|
Next Message | Greg Stark | 2006-06-09 22:22:07 | ADD/DROP INHERITS |
Previous Message | Andreas Pflug | 2006-06-09 09:34:23 | Re: Patch for - Allow server logs to be remotely read |