| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | David Steele <david(at)pgmasters(dot)net>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: More tests to stress directly checksum_impl.h |
| Date: | 2020-03-08 19:12:11 |
| Message-ID: | 4464.1583694731@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> Thanks for the computations with big-endian! I would have just gone
> down to the 8kB page for the expected results by seeing three other
> tests blowing up, but no objection to what you have here either. I
> have checked the computations with little-endian from your patch and
> these are correct.
After thinking more I concluded that the extra expected files would
just be a waste of tarball space, at least till such time as we make
a push to fix all the regression tests to be blocksize-independent.
Pushed it with just the 8K files.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2020-03-08 19:14:56 | Re: pg11+: pg_ls_*dir LIMIT 1: temporary files .. not closed at end-of-transaction |
| Previous Message | Tom Lane | 2020-03-08 18:37:49 | Re: pg11+: pg_ls_*dir LIMIT 1: temporary files .. not closed at end-of-transaction |