Re: DROP FUNCTION of multiple functions

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: DROP FUNCTION of multiple functions
Date: 2016-12-31 16:17:02
Message-ID: 44639202-2e20-78d4-71bf-e390b4d7bf13@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 12/1/16 9:32 PM, Peter Eisentraut wrote:
> I think it would be better to get rid of objargs and have objname be a
> general Node that can contain more specific node types so that there is
> some amount of type tracking. FuncWithArgs would be one such type,
> Typename would be another, Value would be used for simple strings, and
> we could create some other ones, or stick with lcons for some simple
> cases. But then we don't have to make stuff into one-item lists to just
> to satisfy the currently required List.
>
> That's the general idea. But that's a rather big change that I would
> rather break down into smaller pieces.

People wanted to the whole thing at once, so here it is.

Patches 0001 and 0002 are some prep work. Patch 0003 is the main patch
that removes the objargs fields and changes the objname to a generic
Node*. 0004 is an API simplification that could be committed together
with 0003 but I kept it separate for easier review. 0005 accomplishes
the DROP FUNCTION changes. 0006 is some other cleanup that fell out of
this.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
0001-Add-operator_with_argtypes-grammar-rule.patch text/x-patch 6.0 KB
0002-Use-class_args-field-in-opclass_drop.patch text/x-patch 2.2 KB
0003-Remove-objname-objargs-split-for-referring-to-object.patch text/x-patch 110.6 KB
0004-Replace-LookupFuncNameTypeNames-with-LookupFuncWithA.patch text/x-patch 19.6 KB
0005-Allow-dropping-multiple-functions-at-once.patch text/x-patch 8.8 KB
0006-Combine-DROP-FDW-and-DROP-SERVER-grammar-into-generi.patch text/x-patch 5.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-12-31 16:43:42 Re: Add doc advice about systemd RemoveIPC
Previous Message Peter Eisentraut 2016-12-31 16:08:18 Re: tab complete regress tests