The new SPARC assembly file src/backend/port/tas/solaris_sparc.s uses /
instead of ! for comments, and as a result the compile fails with Sun
Studio 11. Please modify the first 3 lines to look like the following.
> ! solaris_sparc.s -- compare and swap for solaris_sparc
Bruce Momjian wrote On 04/29/06 17:16,:
>Tom Lane wrote:
>>Theo Schlossnagle <jesus(at)omniti(dot)com> writes:
>>>I'd remind everyone that the spinlock stuff is entirely optional at
>>Not really. The performance hit for not having hardware spinlocks is
>>so severe that it's not considered a reasonable fallback.
>>>I also think it immensely useful to replace all of the tas subsystem
>>>with cas so that one could reliabily lock these atomics with the process
>>>id of the locker.
>>I cannot, ever once in my years working on Postgres, remember having
>>wanted such a thing. I am strongly against mucking with the spinlock
>>code for mere aesthetics --- it's too fragile and hard to test,
>>especially on platforms you don't have ready access to.
>>In short, it ain't broken and we don't need to fix it.
>Agreed. Should the new Solaris ASM code be modified?
In response to
pgsql-bugs by date
|Next:||From: Tang, Guo||Date: 2006-05-04 21:10:46|
|Subject: question on PostgreSQL\8.0\pgAdmin III|
|Previous:||From: Casey Duncan||Date: 2006-05-04 17:23:12|
|Subject: ERROR: out of memory, running aggregate query|
pgsql-patches by date
|Next:||From: Tom Lane||Date: 2006-05-04 19:36:53|
|Subject: Re: patch review, please: Autovacuum/Vacuum times via stats. |
|Previous:||From: Martijn van Oosterhout||Date: 2006-05-04 18:46:24|
|Subject: Re: [PATCH] Have configure complain about unknown options|