Re: Avoiding repeated snapshot computation

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org, Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>
Subject: Re: Avoiding repeated snapshot computation
Date: 2011-11-26 20:52:17
Message-ID: 4427.1322340737@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> You could also try if it makes a difference reducing SnapshotData to one
> instead of two cachelines. The data itself fits into one without problems.
> Trivial patch attached.

On what grounds do you argue that this patch gets SnapshotData into one
cacheline today (and on what hardware), or that it will continue to do
so in the future? If we're this close to the edge then any future
addition to the struct will destroy the point. I'd just as soon keep
the fields in a logical order.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2011-11-26 20:58:01 Re: [PATCH] PostgreSQL fails to build with 32bit MinGW-w64
Previous Message Andres Freund 2011-11-26 20:42:12 Re: Avoiding repeated snapshot computation