Re: [PATCH] Use PKG_CHECK_MODULES to detect the libxml2 library

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Hugh McMaster <hugh(dot)mcmaster(at)outlook(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Use PKG_CHECK_MODULES to detect the libxml2 library
Date: 2020-03-16 21:04:05
Message-ID: 440ACAAB-1F0C-4DAB-92FC-22169723CFEB@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 16 Mar 2020, at 17:12, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> Still, I think the number of people who'd get bit by that could be
> counted without running out of fingers, while it seems quite likely
> that many people will soon need to build our back branches on
> platforms that won't have xml2-config.

I agree with this assessment.

> So I'm now leaning to "back-patch and make sure to mention this in
> the next release notes". Barring objections, I'll do that soon.

None from me.

> I don't have a problem with s/libxml/libxml2/ in the running text
> (without changing the switch name).

+1

> Can't get too excited about
> <productname> though. I think we've only consistently applied
> that tag to PostgreSQL itself.

Fair enough. Looking at a random sample it seems we use a bit of a mix of
nothing, <application /> and <productname /> (the latter ones being more or
less equal in DocBook IIRC) to mark up externals.

cheers ./daniel

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2020-03-16 21:04:22 nbtree: Refactor "fastpath" and _bt_search() code
Previous Message Alvaro Herrera 2020-03-16 20:30:40 Re: pgsql: Add kqueue(2) support to the WaitEventSet API.