Re: pgxs/windows

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Magnus Hagander <mha(at)sollentuna(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pgxs/windows
Date: 2006-01-15 21:56:52
Message-ID: 43CAC524.8050704@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:

>"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
>
>
>>As you see, it adds both bin and lib.
>>
>>
>
>Is the bin part even necessary?
>
>It looks to me like the -L for libdir is coming from Makefile.global.in:
>
># add location of libpgport.a to LDFLAGS
>ifdef PGXS
>override LDFLAGS := -L$(libdir) $(LDFLAGS)
>else
>override LDFLAGS := -L$(top_builddir)/src/port $(LDFLAGS)
>endif
>
>Comparing that to the code in Makefile.win32, one of them is wrong
>about the need for $(DESTDIR). Perhaps that has something to do with
>it not working for Andrew?
>
>

I doubt DESTDIR is having an effect. From what I can see we hardly use
it so it will mostly be blank:

[andrew(at)alphonso pgsql.head]$ grep -r DESTDIR.\*= .
./src/test/regress/pg_regress.sh: $GMAKE -C "$top_builddir"
DESTDIR="$temp_install/install" install with_perl=no with_python=no
>"$LOGDIR/install.log" 2>&1
[andrew(at)alphonso pgsql.head]$

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-01-15 22:02:54 Re: pgxs/windows
Previous Message korry 2006-01-15 19:01:59 Re: Coding standards? Recommendations?

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2006-01-15 22:02:54 Re: pgxs/windows
Previous Message Tom Lane 2006-01-15 18:09:40 Re: pgxs/windows