Re: [PATCHES] snprintf() argument reordering not working

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgman(at)candle(dot)pha(dot)pa(dot)us, ntufar(at)gmail(dot)com, devrim(at)kivi(dot)com(dot)tr, mha(at)sollentuna(dot)net, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCHES] snprintf() argument reordering not working
Date: 2005-12-05 15:44:45
Message-ID: 4394606D.8050008@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:

>Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>
>
>>However, a very simple test shows that the libintl printf does indeed do
>>%m$ processing:
>>...
>>So the next question is why isn't it working in the build.
>>
>>
>
>Is it possible that the build that was being complained of was using our
>previous, very-broken snprintf.c?
>
>
>
>

There's currently a config setting that is supposed to inhibit its use
on Windows. I am quite confused.

What is more, when I set the locale of my machine to Turkish and run the
installer project's 8.1_RC1 which I happen to have installed there, and
set lc_messages to tr_TR.UTF-8, I don't see lines like Nicolai reported:

LOG: "$s" veritaban?n transaction ID warp limiti $u

I see this:

LOG: "2147484146" veritabanin transaction ID warp limiti postgres

So I'm inclined to think there might be something odd about his setup and maybe we aren't quite so broken after all.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2005-12-05 15:56:14 Re: [PATCHES] snprintf() argument reordering not working
Previous Message Alvaro Herrera 2005-12-05 15:08:55 Re: Reducing relation locking overhead

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2005-12-05 15:56:14 Re: [PATCHES] snprintf() argument reordering not working
Previous Message Tom Lane 2005-12-05 14:35:57 Re: [PATCHES] snprintf() argument reordering not working