Re: Cygwin PostgreSQL Regression Test Problems

Jason Tishler <Jason(dot)Tishler(at)dothill(dot)com> writes:
> /* FIXME: this delqueue module is very flawed and should be rewritten.
> First, having an array of a fixed size for keeping track of the
> unlinked but not yet deleted files is bad. Second, some programs
> will unlink files and then create a new one in the same location
> and this behavior is not supported in the current code. Probably
> we should find a move/rename function that will work on open files,
> and move delqueue files to some special location or some such
> hack... */

> With the above caveats, is the current functionality sufficient for
> PostgreSQL's needs?

The fixed-size-array thing sounds like a gotcha waiting to bite someone.
How big is the array, anyway?

The unlink/recreate issue is not a problem for us anymore, since we use
OIDs as filenames --- we won't try to reuse the same filename.

regards, tom lane