[Fwd: Re: regression failures on WIndows in machines with some non-English locales]

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Cc: Petr Jelinek <pjmodos(at)seznam(dot)cz>
Subject: [Fwd: Re: regression failures on WIndows in machines with some non-English locales]
Date: 2005-11-01 12:43:15
Message-ID: 436762E3.1000106@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


This has refreshed my fading memory. The patch seems like the best
solution. Is there any objection to applying it?

(Petr, I assume you intended to send this to a mailing list also)

cheers

andrew

-------- Original Message --------
Subject: Re: regression failures on WIndows in machines with some
non-English locales
Date: Tue, 01 Nov 2005 07:55:59 +0100
From: Petr Jelinek <pjmodos(at)seznam(dot)cz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>
References: <4366C2AE(dot)70500(at)dunslane(dot)net> <21289(dot)1130816310(at)sss(dot)pgh(dot)pa(dot)us>

BTW Tom you should know it's not really failure it's just different
sorting of output in rules test (due to "ch" being one letter in my locale).

When I suggested --no-locale for regression test I ment something like
whats in attachement - this will not change current functionality just
adds option to set NO_LOCALE=something in make check commandline which
would enable me to setup buildfarm member (after patching buildfarm
client, I think it should be option which is off by default there too).

I want this aproach because forcing --no-locale for everybody could mean
that we won't find some errors - good example of this is "force C
locale for temp regression installations" thread
(http://archives.postgresql.org/pgsql-patches/2005-08/msg00352.php)
where we discussed it, you both might remmeber it.

--
Regards
Petr Jelinek (PJMODOS)

Attachment Content-Type Size
regress-nolocale.diff text/plain 4.6 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2005-11-01 13:35:48 Re: Adding a column in pg_proc for storing default values of arguments
Previous Message Paul Lindner 2005-11-01 12:15:50 Re: Differences in UTF8 between 8.0 and 8.1