| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Magnus Hagander <mha(at)sollentuna(dot)net>, Qingqing Zhou <zhouqq(at)cs(dot)toronto(dot)edu>, pgsql-hackers(at)postgresql(dot)org, Merlin Moncure <merlin(dot)moncure(at)rcsonline(dot)com> |
| Subject: | Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance |
| Date: | 2005-10-24 00:21:44 |
| Message-ID: | 435C2918.8050906@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
>"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
>
>
>>Here's another version of this patch ;-) I've based it on your patch, so
>>the changes to ovalue etc should sitill be there.
>>
>>
>
>In the spirit of incremental improvement ... I've taken Magnus' version
>and added the proposed change to re-enable Qingqing's patch by skipping
>WaitForSingleObjectEx altogether in the CHECK_FOR_INTERRUPTS code path.
>I also removed WaitForSingleObjectEx in pgwin32_poll_signals(), which
>AFAICS should be just like CHECK_FOR_INTERRUPTS. I think this is what
>we are proposing to actually apply to 8.1beta4. I can't test it though,
>so please check it over...
>
>
>
This patch passes regression and demonstrates the expected speedup on my
machine.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nicholas | 2005-10-24 00:26:35 | BUG #1993: Adding/subtracting negative time intervals changes time zone of result |
| Previous Message | Magnus Hagander | 2005-10-23 20:56:10 | Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance |