Re: patch for pg_autovacuum 8.0.x prevent segv for dropped

From: "Matthew T(dot) O'Connor" <matthew(at)zeut(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: daveg <daveg(at)sonic(dot)net>, pgsql-patches(at)postgresql(dot)org
Subject: Re: patch for pg_autovacuum 8.0.x prevent segv for dropped
Date: 2005-10-20 16:24:48
Message-ID: 4357C4D0.40105@zeut.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> daveg <daveg(at)sonic(dot)net> writes:
>
>> Below is a patch for this that should apply against any 8.0.x. The change
>> verifies that the catalog query returned some rows before accessing the row
>> data.
>>
>
> Surely this is completely broken? AFAICT you are testing the result
> from a VACUUM or ANALYZE command, which is not going to return any
> tuples.

Upon further inspection, I think you are right. I would think that
instead of checking the query result with PQntuples, it should probably
be checked with |PQresultStatus.

Matt

|

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Chris Browne 2005-10-20 16:27:41 AIX FAQ update for 5.3 socket address size issue
Previous Message Tom Lane 2005-10-20 16:06:51 Re: patch for pg_autovacuum 8.0.x prevent segv for dropped tables