| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | David Fetter <david(at)fetter(dot)org>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Code review for spi_query/spi_fetchrow patch: |
| Date: | 2005-10-19 13:33:21 |
| Message-ID: | 43564B21.9060609@dunslane.net |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Tom Lane wrote:
>David Fetter <david(at)fetter(dot)org> writes:
>
>
>>On Tue, Oct 18, 2005 at 02:13:14PM -0300, Tom Lane wrote:
>>
>>
>>>Log Message:
>>>-----------
>>>Code review for spi_query/spi_fetchrow patch: handle errors sanely,
>>>avoid leaking memory. I would add a regression test for error
>>>handling except it seems eval{} can't be used in unprivileged plperl
>>>:-(
>>>
>>>
>
>
>
>>What would you be using the eval{} to do?
>>
>>
>
>Catch the error inside the Perl function.
>
>
>
>
We could load plperlu in addition to plperl for the regression tests -
IIRC you made me make provision for loading multiple languages :-)
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | User Am | 2005-10-19 14:32:09 | press - pr: Partial translation of the press release to Romanian. |
| Previous Message | User Dpage | 2005-10-19 08:47:29 | pginstaller - pginst: Include pgAdmin3's Spanish hint files |