| From: | Joe Conway <mail(at)joeconway(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>, David Fetter <david(at)fetter(dot)org>, Jonathan Beit-Aharon <jbeitaharon(at)intrusic(dot)com> |
| Subject: | Re: [HACKERS] Patching dblink.c to avoid warning about |
| Date: | 2005-10-17 02:21:12 |
| Message-ID: | 43530A98.3020507@joeconway.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Tom Lane wrote:
> I think it would be shorter and clearer to write
>
> remoteConn *remconn = NULL;
> ...
> remconn = rconn;
> ...
> remconn->newXactForCursor = TRUE;
>
> Also, you might be able to combine this variable with the existing
> rconn local variable and thus simplify the code even more.
Thanks for the review Tom -- as usual, great suggestions. The attached
(simpler) patch makes use of your advice. If there are no objections,
I'll apply this tomorrow evening.
Joe
| Attachment | Content-Type | Size |
|---|---|---|
| current.dblink.2.diff | text/x-patch | 15.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | NosyMan | 2005-10-17 06:55:50 | Can I use variable to store sql data? |
| Previous Message | Tom Lane | 2005-10-16 22:10:38 | Re: Will PQregisterThreadLock() be documented? |