altering table properties

From: Miha Radej <miha(dot)radej(at)siix(dot)com>
To: PgAdmin Hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: altering table properties
Date: 2005-09-23 12:14:06
Message-ID: 4333F18E.3020904@siix.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers pgadmin-support

hi!

thank you for fixing the sql query order in svn. i have, however,
noticed some other things which might be annoying:

when wanting to change a table name and a column name at the same time,
pgadmin produces this (this is all done via the properties option from
the context menu):

ALTER Table budgettype RENAME TO budget_type;
ALTER TABLE budgettype RENAME budgettype_name TO budget_type_name;

which will fail because the table name ought to get changed with the
first query. pgadmin keeps working with the original table name instead
of using the new table name after issuing the rename table statement.
and, not wanting to nag, but to be consistent, the keyword "Table" ought
to be uppercase, like everything else ;)

also, i wanted to remove a constraint (primary key) and add a new one
and pgadmin produced thie following code:

CONSTRAINT ALTER TABLE budget_type DROP CONSTRAINT pkey_budgettype;
ALTER TABLE budget_type ADDpkey_budget_type PRIMARY KEY (id);

there is an unneccesary " CONSTRAINT " in front of the first query and
in the second query there is no space between the ADD keyword and
constraint name.

i am using pgadmin3 compiled from svn (fresh checkout from an hour ago),
on suse linux 9.3.

cheers,
Miha

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Miha Radej 2005-09-23 12:27:17 Re: altering table properties
Previous Message svn 2005-09-23 08:56:53 SVN Commit by dpage: r4459 - in trunk/pgadmin3/src: dlg schema

Browse pgadmin-support by date

  From Date Subject
Next Message Miha Radej 2005-09-23 12:27:17 Re: altering table properties
Previous Message Vasilev Max 2005-09-23 07:52:19 Re: Bug/Feature request: Parameter names