Re: A note about debugging TAP failures

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Craig Ringer <craig(dot)ringer(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: A note about debugging TAP failures
Date: 2017-09-05 19:04:57
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> On 05 Sep 2017, at 18:37, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> On 4/25/17 11:00, Daniel Gustafsson wrote:
>> Makes sense, assuming a “clean slate” to run on seems a reasonable assumption
>> for the test and it makes for simpler code in PostgresNode. Updated the patch
>> which now have static datadir names; retains on PG_TESTS_NOCLEAN or any kind of
>> test failure; and allows for cleaning datadirs without having to use make clean
>> (seems the wrong size hammer for that nail).
> Committed. I had to make some changes in the pg_rewind tests. Those
> make data directories with conflicting names, which did not work anymore
> because the names are no longer random.

Makes sense, +1 on those changes.

> Other than that this is pretty nice. Thanks!

Thanks for the commit!

cheers ./daniel

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2017-09-05 19:06:54 Re: psql - add special variable to reflect the last query status
Previous Message Fabien COELHO 2017-09-05 19:01:25 Re: [COMMITTERS] pgsql: Add psql variables showing server version and psql version.