Re: pg_ctl and port number detection

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_ctl and port number detection
Date: 2010-12-18 23:02:25
Message-ID: 4326.1292713345@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> pg_ctl.c::test_postmaster_connection() has some fragile code that tries
> to detect the server port number by looking in the pg_ctl -o string,

It may be fragile, but it works; or at least I've not heard complaints
about it lately.

> I think a simpler solution would be to look in postmaster.pid:
> pg_ctl already knows the data directory. If the file is missing, the
> server is not running. If the file exists, the first number on the last
> line, divided by 1000, is the port number.

That's somewhere between fragile and outright wrong.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2010-12-18 23:08:04 Re: pg_ctl and port number detection
Previous Message Dimitri Fontaine 2010-12-18 19:39:42 Extensions, patch v20 (bitrot fixes) (was: Extensions, patch v19 (encoding brainfart fix))