Re: compilation errors: wrong actions

From: Andreas Pflug <pgadmin(at)pse-consulting(dot)de>
To: Diego Gil <diego(at)adminsa(dot)com>
Cc: PgAdmin Hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: compilation errors: wrong actions
Date: 2005-08-18 07:13:03
Message-ID: 430434FF.4060202@pse-consulting.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Diego Gil wrote:
> Andreas:
>
> after a new checkout, new errors appears :
>
> .
> .
> .
> .
> ./src/include/pgUser.h:18: warning: 'class pgUserFactory' has virtual
> functions but non-virtual destructor

These are all bullsh*t. Factories are never deleted.
> ../src/agent/include/pgaJob.h:19: warning: 'class pgaJobFactory' has
> virtual functions but non-virtual destructor
> ./schema/pgServer.cpp: In member function 'virtual void
> pgServer::ShowTreeDetail(ctlTree*, frmMain*, ctlListView*, ctlSQLBox*)':
> ./schema/pgServer.cpp:738: error: 'groupRoleFactory' was not declared in
> this scope
> ./schema/pgServer.cpp:739: error: 'loginRoleFactory' was not declared in
> this scope

Yup, I broke *ix compilation because I didn't checkin the new role
files. These aren't fully tested, will take some days to do that.
To fix temporarily, simply use the previous pgServer.cpp.
This is the advantage of the new factory architecture: only pgServer
knows it might have role childs, the rest of pgAdmin is completely role
agnostic.

Regards,
Andreas

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Diego Gil 2005-08-18 14:16:04 Re: compilation errors: wrong actions
Previous Message Diego Gil 2005-08-17 23:17:51 Re: compilation errors: wrong actions