| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Alon Goldshuv <agoldshuv(at)greenplum(dot)com> |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: COPY FROM performance improvements |
| Date: | 2005-07-19 15:23:18 |
| Message-ID: | 42DD1AE6.6020204@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches pgsql-performance |
Alon Goldshuv wrote:
>I revisited my patch and removed the code duplications that were there, and
>added support for CSV with buffered input, so CSV now runs faster too
>(although it is not as optimized as the TEXT format parsing). So now
>TEXT,CSV and BINARY are all parsed in CopyFrom(), like in the original file.
>
>Patch attached.
>
>
>
I do not have time to review this 2900 line patch analytically, nor to
benchmark it. I have done some functional testing of it on Windows, and
tried to break it in text and CSV modes, and with both Unix and Windows
type line endings - I have not observed any breakage.
This does need lots of eyeballs, though.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jim C. Nasby | 2005-07-19 18:40:25 | Re: Patch to fix plpython on OS X |
| Previous Message | Tom Lane | 2005-07-19 14:03:39 | Re: Patch to fix plpython on OS X |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | PFC | 2005-07-19 15:33:21 | Re: Impact of checkpoint_segments under continual load conditions |
| Previous Message | Tom Lane | 2005-07-19 15:04:30 | Re: Impact of checkpoint_segments under continual load conditions |