Re: [PATCHES] HEAD doesn't cope with libraries in non-default

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, decibel(at)decibel(dot)org, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCHES] HEAD doesn't cope with libraries in non-default
Date: 2005-07-13 19:46:23
Message-ID: 42D56F8F.1080208@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:

>Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>
>
>>which looks very odd indeed, especially:
>>
>>
>
>
>
>> -L -L../../../src/backend -L../../../src/port -L/c/tcl/lib C:/Perl/lib/CORE -lperl58
>>
>>
>
>Ah, I see the problem:
>
>ifeq ($(PORTNAME), win32)
>perl_archlibexp := $(subst \,/,$(perl_archlibexp))
>perl_privlibexp := $(subst \,/,$(perl_privlibexp))
>perl_embed_ldflags := -L $(perl_archlibexp)/CORE -lperl58
> ^^^^^^^^^^^^^^^^^^^^^^^^^^
>override CPPFLAGS += -DPLPERL_HAVE_UID_GID
>endif
>
>The filter hack depends on -L and the following argument to not be
>space-separated. We made the no-space assumption before for -L in
>LDFLAGS, but not for -L in SHLIB_LINK.
>
>I've removed the space in CVS tip, we'll see where that takes us.
>
>
>
>

Seems to have done the trick on Windows. I think this stuff is now fixed
- thanks for your help.

cheers

andrew

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2005-07-13 19:51:10 Re: windows regression failure - prepared xacts
Previous Message Jim C. Nasby 2005-07-13 19:27:17 pthread stack on FreeBSD WAS: HEAD doesn't cope with libraries in non-default

Browse pgsql-patches by date

  From Date Subject
Next Message Titus von Boxberg 2005-07-14 00:32:23 PL/PGSQL: Dynamic Record Introspection
Previous Message Jim C. Nasby 2005-07-13 19:27:17 pthread stack on FreeBSD WAS: HEAD doesn't cope with libraries in non-default