Re: regexp_replace

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Atsushi Ogawa <a_ogawa(at)hi-ho(dot)ne(dot)jp>, pgsql-patches(at)postgresql(dot)org
Subject: Re: regexp_replace
Date: 2005-07-10 16:49:38
Message-ID: 42D151A2.1030309@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


The change below has broken tsearch2. See for example
http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=shrew&dt=2005-07-10%2015:02:01

cheers

andrew

Bruce Momjian wrote:

>I have applied your patch, with slight adjustments in spacing and
>documentation.
>
>Patch applied. Thanks.
>
>
>
[snip]

>Index: src/include/regex/regex.h
>===================================================================
>RCS file: /cvsroot/pgsql/src/include/regex/regex.h,v
>retrieving revision 1.26
>diff -c -c -r1.26 regex.h
>*** src/include/regex/regex.h 29 Nov 2003 22:41:10 -0000 1.26
>--- src/include/regex/regex.h 10 Jul 2005 04:52:51 -0000
>***************
>*** 163,169 ****
> * the prototypes for exported functions
> */
> extern int pg_regcomp(regex_t *, const pg_wchar *, size_t, int);
>! extern int pg_regexec(regex_t *, const pg_wchar *, size_t, rm_detail_t *, size_t, regmatch_t[], int);
> extern void pg_regfree(regex_t *);
> extern size_t pg_regerror(int, const regex_t *, char *, size_t);
>
>--- 163,169 ----
> * the prototypes for exported functions
> */
> extern int pg_regcomp(regex_t *, const pg_wchar *, size_t, int);
>! extern int pg_regexec(regex_t *, const pg_wchar *, size_t, size_t, rm_detail_t *, size_t, regmatch_t[], int);
> extern void pg_regfree(regex_t *);
> extern size_t pg_regerror(int, const regex_t *, char *, size_t);
>
>
>
>

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Satoshi Nagayasu 2005-07-11 03:13:20 Re: A couple of p.tches for PostgreSQL 64bit support
Previous Message Bruce Momjian 2005-07-10 15:32:51 Re: plperl return array support revisited