| From: | Mark Kirkwood <markir(at)paradise(dot)net(dot)nz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Neil Conway <neilc(at)samurai(dot)com>, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: TODO Item - Return compressed length of TOAST datatypes |
| Date: | 2005-07-07 04:34:18 |
| Message-ID: | 42CCB0CA.7000107@paradise.net.nz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Tom Lane wrote:
> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
>
>>On Thu, Jul 07, 2005 at 03:01:46PM +1200, Mark Kirkwood wrote:
>>
>>>I have attached a little change to varlena.c that uses it. I left the
>>>ereport as it was, but am not fussed about it either way.
>
>
>>I am, because it gives useless messages to the translators to work on.
>
>
> Exactly. I had already made a private note to fix that patch ---
> inventing your own random wording and punctuation for an extremely
> standard error message is simply Not Acceptable.
>
Apologies all, my "not fussed about it" was highly misleading - I had
already changed the error message as per Neil's suggestion in the
revised patch, but that was not obvious from my comment :-(
regards
Mark
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2005-07-07 04:36:10 | Re: TODO Item - Return compressed length of TOAST datatypes |
| Previous Message | Tom Lane | 2005-07-07 04:28:21 | Re: TODO Item - Return compressed length of TOAST datatypes |