| From: | Mark Kirkwood <markir(at)paradise(dot)net(dot)nz> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Neil Conway <neilc(at)samurai(dot)com>, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: TODO Item - Return compressed length of TOAST datatypes |
| Date: | 2005-07-07 03:45:16 |
| Message-ID: | 42CCA54C.8080906@paradise.net.nz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Alvaro Herrera wrote:
> On Thu, Jul 07, 2005 at 03:01:46PM +1200, Mark Kirkwood wrote:
>
>>Neil Conway wrote:
>
>
>>>elog(ERROR) is usually used for "can't happen" errors.
>>
>>I have attached a little change to varlena.c that uses it. I left the
>>ereport as it was, but am not fussed about it either way.
>
>
> I am, because it gives useless messages to the translators to work on.
> elog parameters are not marked for translation, ereport are (errmsg and
> friends, really). So please don't do that.
>
Ok, didn't realize the difference! Revised patch attached that uses elog.
Neil, I will runs some tests to see if there is any performance saving
with the first-call-only business.
Cheers
Mark
| Attachment | Content-Type | Size |
|---|---|---|
| varlena.c.diff | text/plain | 1.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2005-07-07 04:14:38 | Re: TODO Item - Return compressed length of TOAST datatypes |
| Previous Message | Alvaro Herrera | 2005-07-07 03:28:23 | Re: TODO Item - Return compressed length of TOAST datatypes |