Re: [PATCH] pgcrypto: pgp_encrypt (v2)

From: Neil Conway <neilc(at)samurai(dot)com>
To: Marko Kreen <marko(at)l-t(dot)ee>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org
Subject: Re: [PATCH] pgcrypto: pgp_encrypt (v2)
Date: 2005-07-04 06:59:58
Message-ID: 42C8DE6E.3050901@samurai.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Marko Kreen wrote:
> Please use following updated patch instead.
>
> It implements utf8 conversion, fixes couple of bugs and has
> many code and comment cleanups.

The regression tests don't pass on my box. With the default Makefile,
there are a lot of errors WRT "no strong random source". After editing
the Makefile to make use the "random" device, I get the attached
regression.diffs.

While I understand the need to make sure people use a reasonably strong
crypto source, it would be nice if the regression tests passed out of
the box.

-Neil

Attachment Content-Type Size
regression.diffs text/plain 12.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Neil Conway 2005-07-04 07:07:47 Re: User's exception plpgsql
Previous Message Marc G. Fournier 2005-07-04 04:51:17 Re: Schedule for release 8.1

Browse pgsql-patches by date

  From Date Subject
Next Message Neil Conway 2005-07-04 07:07:47 Re: User's exception plpgsql
Previous Message Neil Conway 2005-07-04 06:39:51 Re: tiny patch to fic unixware build