From: | Satoshi Nagayasu <nagayasus(at)nttdata(dot)co(dot)jp> |
---|---|
To: | Neil Conway <neilc(at)samurai(dot)com> |
Cc: | pgsql-patches(at)postgresql(dot)org |
Subject: | Re: enable/disable trigger (Re: Fwd: [HACKERS] Open items) |
Date: | 2005-07-01 08:32:56 |
Message-ID: | 42C4FFB8.2080803@nttdata.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Thanks for comments, Neil.
Some are fixed.
Neil Conway wrote:
> Also, you should probably skip the simple_heap_update() if the user
> tries to disable an already-disabled trigger, to avoid pointless MVCC
> bloat (and same for enabling an already-enabled trigger, of course).
Do we need some log/warning message for the user in these cases?
> If someone pg_dump's a table with a disabled trigger, should the dump
> enable or disable the trigger? I'd be inclined to say pg_dump should
> preserve the state of the database it is dumping, and so the trigger
> should be disabled. In that case I believe pg_dump needs to be updated.
I think so too.
> The patch needs to update the documentation and add regression tests.
> psql tab completion might also be worth adding.
I'll dive into pg_dump and psql this weekend...
--
NAGAYASU Satoshi <nagayasus(at)nttdata(dot)co(dot)jp>
Attachment | Content-Type | Size |
---|---|---|
trig.diff | text/plain | 7.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Satoshi Nagayasu | 2005-07-01 08:56:29 | Re: enable/disable trigger (Re: Fwd: [HACKERS] Open items) |
Previous Message | Neil Conway | 2005-07-01 08:10:57 | Re: enable/disable trigger (Re: Fwd: [HACKERS] Open items) |
From | Date | Subject | |
---|---|---|---|
Next Message | Satoshi Nagayasu | 2005-07-01 08:56:29 | Re: enable/disable trigger (Re: Fwd: [HACKERS] Open items) |
Previous Message | Neil Conway | 2005-07-01 08:10:57 | Re: enable/disable trigger (Re: Fwd: [HACKERS] Open items) |