Re: soundex and metaphone

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Jonah H(dot) Harris" <jharris(at)tvi(dot)edu>, Douglas McNaught <doug(at)mcnaught(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: soundex and metaphone
Date: 2005-05-26 15:17:44
Message-ID: 4295E898.5060606@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:

>"Jonah H. Harris" <jharris(at)tvi(dot)edu> writes:
>
>
>>At a minimum I think we should support soundex in the core. I'm willing
>>to move soundex and metaphone into the backend. Does anyone see a
>>reason not to do so?
>>
>>
>
>Is it really ready for prime time? For one thing, a quick look shows no
>evidence of being multibyte-ready. There's a fair amount of cleanup of
>random private coding conventions (META_MALLOC!?) to be done too.
>
>Doug's point is valid: there's some actual work needed here, not just
>arguing to shove the code from point A to point B.
>
>
>
>

Well, META_MALLOC occurs in part of the code that he didn't ask for ...
it was inherited from the perl module code that I adapted to do double
metaphone. And a minimal wrapper suited my purposes at the time just fine.

But the point is well taken nevertheless.

cheers

andrew

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2005-05-26 15:18:58 Re: Regression failures: time, timetz, horology
Previous Message Stephan Szabo 2005-05-26 15:06:12 Re: foreign keys and RI triggers