Re: Implement support for TCP_KEEPCNT, TCP_KEEPIDLE, TCP_KEEPINTVL

From: Oliver Jowett <oliver(at)opencloud(dot)com>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: Implement support for TCP_KEEPCNT, TCP_KEEPIDLE, TCP_KEEPINTVL
Date: 2005-05-26 05:30:27
Message-ID: 42955EF3.6070007@opencloud.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian wrote:
> Where are we on this? I do think it solves a problem that some are
> having, and it seems it would detect a disconnected client and abort a
> long running query.

I haven't had a chance to do any work to support the Solaris stuff, but
otherwise I'm just waiting on review.

Note that the patch doesn't do anything about long-running queries, it's
really about long-running connections/transactions. The server will only
notice the disconnected client once it tries to read/write something.

> I am not very excited about adding four more GUC variables, and I am
> thinking we could just have it use the OS defaults and see if we need
> more later, so that would add only one GUC.

The whole point of the patch is that the system-wide defaults are
usually not useful. The current, unpatched, server turns on SO_KEEPALIVE
always, but the typical OS defaults set the timeout before probing to
about 2 hours.

-O

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Qingqing Zhou 2005-05-26 05:59:04 Can we simplify win32 threading code
Previous Message David Fetter 2005-05-26 03:23:36 Josh Narins' Subcountry System

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2005-05-26 05:32:02 Re: Remove second argument from textToQualifiedNameList
Previous Message Neil Conway 2005-05-26 05:08:46 Re: Remove second argument from textToQualifiedNameList